Use checked_length
when collecting ranges
#58251
Open
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the status quo slightly, as it avoids a segfault if the length computation for the ranges overflow. This is only possible for known
Integer
types inBase
, for which achecked_length
method exists. However, this is enough to address common cases.After this,
Fixes #58245
The performance of
collect
seems unaffected by this change, as this check should be inexpensive compared to the followingsetindex!
.