-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Dimensional any
and all
reduce with Boolean operations
#58185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5301c06
use a boolean operator for any/all, not bitwise
mbauman 31889bf
restore broken Bool behaviors for & and |
mbauman 580bb5e
fix doctests
mbauman fd531e4
test use mapslices instead of mapreduce for all/any
69e4dee
preserve and test more existing behaviors
mbauman 855bef3
Fixup doctests
mbauman 7746c96
use assertion, not conversion
mbauman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -681,6 +681,17 @@ end | |
end | ||
end | ||
|
||
@testset "issue #45562" begin | ||
@test all([true, true, true], dims = 1) == [true] | ||
@test any([true, true, true], dims = 1) == [true] | ||
mbauman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
@test_throws TypeError all([3, 3, 3], dims = 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this line the only intended behavior change of this PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, along with the corresponding change to |
||
@test_throws TypeError any([3, 3, 3], dims = 1) | ||
@test reduce(|, Bool[]) == false | ||
@test reduce(&, Bool[]) == true | ||
@test reduce(|, Bool[], dims=1) == [false] | ||
@test reduce(&, Bool[], dims=1) == [true] | ||
end | ||
mbauman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# issue #45748 | ||
@testset "foldl's stability for nested Iterators" begin | ||
a = Iterators.flatten((1:3, 1:3)) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.