fix inexact conversion of Rational to Integer exception type
#55758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
error handling
vtjnash
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Probably need to make the same fix here?
Line 192 in 945517b
| @@ -147,9 +147,9 @@ end | |||
| Rational(x::Rational) = x | |||
|
|
|||
| Bool(x::Rational) = x==0 ? false : x==1 ? true : | |||
| throw(InexactError(:Bool, Bool, x)) # to resolve ambiguity | |||
| throw(InexactError(:convert, Bool, x)) # to resolve ambiguity | |||
There was a problem hiding this comment.
I think this can stay as :Bool?
| (::Type{T})(x::Rational) where {T<:Integer} = (isinteger(x) ? convert(T, x.num)::T : | ||
| throw(InexactError(nameof(T), T, x))) | ||
| throw(InexactError(:convert, T, x))) |
There was a problem hiding this comment.
We could put a sentinel value here like Symbol(""), in which case the printer for InexactError knows to show the type as the called object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55756