fix: Validate constructed date has year within typemin/max #54933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimikage
reviewed
Jun 25, 2024
Comment on lines
+18
to
+24
| hi -= st # Prevent overshooting | ||
| while v <= hi && prev <= v | ||
| prev = v | ||
| v += st | ||
| i += 1 | ||
| end | ||
| return i - 1 | ||
| return i |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
ah, this is still a work in progress to figure out how to do this. The range implementations currently rely on being able to go past the actual end of the supported range, and now that that errors, this needs to be rethought (it doesn't quite work correctly yet)
There was a problem hiding this comment.
Perhaps it would help to extend the constructable dates from typemin(Date):typemax(Date) to the slightly larger set of representable dates typemin(Date)-Day(161):typemax(Date)+Day(280)
Comment on lines
+252
to
+253
| const DATETIME_YEAR_TYPEMAX = 146138512 | ||
| const DATETIME_YEAR_TYPEMIN = -146138511 |
There was a problem hiding this comment.
I appreciate factoring out these magic numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that a constructed
Datehas a year that's within the range of the type's min and max values.Closes #50981