Implement reverse for more Matrix variants #54231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fatteneder merged 64 commits into JuliaLang:master from Sahiti004:changes

May 22, 2024

Contributor

Sahiti004 commented Apr 24, 2024 •

edited by tecosaur

Loading

This pull request resolves JuliaLang/LinearAlgebra.jl#990: Now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg matrices.

Sahiti004 and others added 2 commits

April 24, 2024 20:48


          making reverse work for Diagonal, symmetric, Tridiagonal, triangular …

15ab357

…etc..


          Merge branch 'JuliaLang:master' into changes

f864755

Sahiti004 changed the title ~~This pull request addresses issue #53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg~~ This pull request resolves issue #53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg

Sahiti004 changed the title ~~This pull request resolves issue #53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg~~ This pull request resolves #53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg

tecosaur added the linear algebra label

Member

tecosaur commented Apr 24, 2024

Thanks for making this PR @Sahiti004! It's great to see such a quick turnaround from your involvement in JuliaLang/LinearAlgebra.jl#990.

I'll just tidy up the PR title/description a bit to make it fit a little better with the usual "subject line + description" format 🙂

Sahiti004 closed this

tecosaur changed the title ~~This pull request resolves #53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg~~ Implement reverse for more Matrix variants

tecosaur mentioned this pull request

This pull request fixes JuliaLang/julia/#53237, now reverse works for Diagonal, Bidiagonal, Tridiagonal, SymTridiagonal, Symmetric, Hermitian, Uppertriangular, LowerTriangular and UpperHessenberg #54232

Closed

Sahiti004 reopened this

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/bidiag.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/bidiag.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/hessenberg.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/hessenberg.jl Outdated Show resolved Hide resolved

LilithHafner reviewed

View reviewed changes

Member

LilithHafner left a comment

Thanks for the PR!

stdlib/LinearAlgebra/src/bidiag.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/diagonal.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/hessenberg.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/hessenberg.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stdlib/LinearAlgebra/src/tridiag.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/hessenberg.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/tridiag.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/src/tridiag.jl Outdated Show resolved Hide resolved

Member

stevengj commented Apr 24, 2024

Your tests should also check the in-place case, e.g. test:

@test reverse!(copy(A)) = reverse(A) == reverse!(Matrix(A))

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/symmetric.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/triangular.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/tridiag.jl Outdated Show resolved Hide resolved

stevengj reviewed

View reviewed changes

stdlib/LinearAlgebra/test/tridiag.jl Outdated Show resolved Hide resolved

Sahiti004 and others added 10 commits

May 3, 2024 15:55


          Update stdlib/LinearAlgebra/test/tridiag.jl

1948c0b

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/tridiag.jl

51d73ef

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/triangular.jl

775ee20

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/triangular.jl

f96d9b6

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/symmetric.jl

45d89cd

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/symmetric.jl

030efd9

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/diagonal.jl

78f388c

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/diagonal.jl

82af8e4

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update stdlib/LinearAlgebra/test/bidiag.jl

a1da157

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>


          Update symmetric.jl

9951a48

stevengj approved these changes

View reviewed changes


          Merge branch 'master' into changes

3984b74

dkarrasch added merge me and removed merge me labels


          clean-up and fixes

2e42cc7

dkarrasch reviewed

View reviewed changes

stdlib/LinearAlgebra/test/triangular.jl Show resolved Hide resolved

dkarrasch added 2 commits

May 21, 2024 12:31


          Update stdlib/LinearAlgebra/test/triangular.jl

83eddd9


          Update abstractarray.jl: specify eltype

f32a783

stevengj reviewed

View reviewed changes

test/abstractarray.jl Outdated Show resolved Hide resolved


          minor fixes

96f6180

dkarrasch added the merge me label

fatteneder merged commit e51f77a into JuliaLang:master

fatteneder removed the merge me label

lazarusA pushed a commit to lazarusA/julia that referenced this pull request


          Implement reverse for more Matrix variants (JuliaLang#54231)

a3cd5b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels