-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
recommend explicit using Foo: Foo, ...
in package code (was: "using considered harmful")
#42080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c2e519b
warn against `using Foo` in package code
KristofferC f8a4c54
Merge branch 'master' into kc/warn_using
DilumAluthge 5a497c8
Add guidance for using qualified names in packages (#53428)
MasonProtter eb9c668
Merge branch 'master' into kc/warn_using
DilumAluthge aa0ce07
Unify some of the language from #53428
mbauman ca82f8b
make shorter
KristofferC d99b8d1
Update base/docs/basedocs.jl
KristofferC 990cd5c
Update doc/src/manual/modules.md
KristofferC 9cdfc27
Merge branch 'master' into kc/warn_using
DilumAluthge cd7e39b
Update doc/src/manual/modules.md
IanButterworth 8d7a183
Merge branch 'master' into kc/warn_using
IanButterworth 402d284
Apply suggestions from code review
IanButterworth 8b4ae86
Merge branch 'master' into kc/warn_using
DilumAluthge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.