fix #39948, stack overflow due to free typevar during jl_type_intersection2
#39959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
types and dispatch
|
Running the tests for the affected packages with this commit on the 1.6 backport branch here: #39614 (comment). |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…pe_intersection2` (JuliaLang#39959)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…pe_intersection2` (JuliaLang#39959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a complete fix for this, but it seems type intersection sometimes returns a type with free variables, throwing a wrench into the works. The temporary solution is to try not to pass an intersection result back into intersection. In such a case I doubt jl_type_intersection2 could have been doing anything useful anyway, so it seems safe to just disable part of it when that happens.