Skip to content

fix #39948, stack overflow due to free typevar during jl_type_intersection2 #39959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

JeffBezanson
Copy link
Member

I don't have a complete fix for this, but it seems type intersection sometimes returns a type with free variables, throwing a wrench into the works. The temporary solution is to try not to pass an intersection result back into intersection. In such a case I doubt jl_type_intersection2 could have been doing anything useful anyway, so it seems safe to just disable part of it when that happens.

@JeffBezanson JeffBezanson added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 labels Mar 9, 2021
@KristofferC
Copy link
Member

Running the tests for the affected packages with this commit on the 1.6 backport branch here: #39614 (comment).

@JeffBezanson JeffBezanson merged commit 9dc9c2d into master Mar 9, 2021
@JeffBezanson JeffBezanson deleted the jb/fix39948 branch March 9, 2021 20:45
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants