Skip to content

Add some precompiles for Test #37754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add some precompiles for Test #37754

merged 1 commit into from
Oct 1, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 25, 2020

Work improving latency in packages often exploits the tests. It's mildly annoying when the inference time of methods in Test stands out as the major contributors, so let's get rid of that annoyance.

@timholy
Copy link
Member Author

timholy commented Sep 29, 2020

These failures seem weird. Is it possible that the variable named Test is conflicting with the module Test?

@timholy
Copy link
Member Author

timholy commented Sep 29, 2020

Oh wait, it's happening elsewhere too, like #37799.

Work improving latency in packages often exploits the tests. It's mildly
annoying when the inference time of methods in Test stands out as the
major contributors, so let's get rid of that annoyance.
@timholy timholy force-pushed the teh/precompile_test branch from 8952a0a to a55d554 Compare September 30, 2020 08:02
@timholy timholy merged commit 0d52973 into master Oct 1, 2020
@timholy timholy deleted the teh/precompile_test branch October 1, 2020 07:13
@StefanKarpinski
Copy link
Member

It's this one: #37731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants