Skip to content

[release-1.4] Set VERSION to 1.4.0-rc1 #34452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

[release-1.4] Set VERSION to 1.4.0-rc1 #34452

merged 1 commit into from
Jan 23, 2020

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan added the release Release management and versioning. label Jan 20, 2020
@ararslan ararslan added this to the 1.4 milestone Jan 20, 2020
@rfourquet
Copy link
Member

#32414 is on the 1.4 milestone, is it planned to be fixed after RC1 ?

@KristofferC
Copy link
Member

Maybe? I don't understand why it is on the milestone though.

@rfourquet
Copy link
Member

I don't understand why it is on the milestone though.

Probably because it was identified as the cause of the failure of BitIntegers (#34288) (I already fixed the other problem with this package on 1.4 related to signed, mentioned there: #34238 (comment))

@KristofferC
Copy link
Member

Previously, it just gave garbage though, right? We just added the assert to catch it in assert builds.

@rfourquet
Copy link
Member

rfourquet commented Jan 21, 2020 •
edited
Loading

Previously, it just gave garbage though, right?

After investigation, you seem to be right: I was testing @test x == y, x was actually not equal to y but the == was still returning true, now it segfaults because of the assertion. I guess this still should not segfault though.

@KristofferC KristofferC self-requested a review January 21, 2020 12:46
KristofferC
KristofferC requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get #34461 in as well

@KristofferC
Copy link
Member

I guess this still should not segfault though.

Ideally, all bugs should be fixed but this is at least an improvement over status quo?

@rfourquet
Copy link
Member

Ideally, all bugs should be fixed but this is at least an improvement over status quo?

Agreed! I will disable the failing test if this doesn't get fixed in 1.4.

KristofferC
KristofferC approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now

@KristofferC KristofferC reopened this Jan 21, 2020
@ararslan
Copy link
Member Author

CI seems not particularly happy

@KristofferC
Copy link
Member

All green now.

@ararslan ararslan merged commit b0c33b0 into release-1.4 Jan 23, 2020
@ararslan ararslan deleted the aa/1.4.0-rc1 branch January 23, 2020 17:23
BioTurboNick pushed a commit to BioTurboNick/julia that referenced this pull request Apr 13, 2020
@ararslan @BioTurboNick
Set VERSION to 1.4.0-rc1 (JuliaLang#34452)
0a5ea4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ararslan @rfourquet @KristofferC @fredrikekre