Skip to content

Commit 0f427e1

Browse files
authored
Merge pull request #38581 from JuliaLang/ksh/mathagain
Small missing tests for math methods
2 parents 377aa80 + a797ad5 commit 0f427e1

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

test/float16.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ end
7676
@test Float16(0.5f0)^2 Float16(0.5f0^2)
7777
@test sin(f) sin(2f0)
7878
@test log10(Float16(100)) == Float16(2.0)
79+
@test sin(ComplexF16(f)) sin(complex(2f0))
7980

8081
# no domain error is thrown for negative values
8182
@test cbrt(Float16(-1.0)) == -1.0

test/math.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,12 +391,18 @@ end
391391
T != Rational{Int} && @test sind(convert(T,-0.0))::fT === -zero(fT)
392392
@test sind(convert(T,-180.0))::fT === -zero(fT)
393393
@test sind(convert(T,-360.0))::fT === -zero(fT)
394+
if T <: AbstractFloat
395+
@test isnan(sind(T(NaN)))
396+
end
394397
end
395398
@testset "cosd" begin
396399
@test cosd(convert(T,90))::fT === zero(fT)
397400
@test cosd(convert(T,270))::fT === zero(fT)
398401
@test cosd(convert(T,-90))::fT === zero(fT)
399402
@test cosd(convert(T,-270))::fT === zero(fT)
403+
if T <: AbstractFloat
404+
@test isnan(cosd(T(NaN)))
405+
end
400406
end
401407
@testset "sincosd" begin
402408
@test sincosd(convert(T,-360))::fTsc === ( -zero(fT), one(fT) )
@@ -407,6 +413,10 @@ end
407413
@test sincosd(convert(T, 90))::fTsc === ( one(fT), zero(fT) )
408414
@test sincosd(convert(T, 180))::fTsc === ( zero(fT), -one(fT) )
409415
@test sincosd(convert(T, 270))::fTsc === ( -one(fT), zero(fT) )
416+
if T <: AbstractFloat
417+
@test_throws DomainError sincosd(T(Inf))
418+
@test all(isnan.(sincosd(T(NaN))))
419+
end
410420
end
411421

412422
@testset "$name" for (name, (sinpi, cospi)) in (

0 commit comments

Comments
 (0)