Skip to content

Commit 377aa80

Browse files
authored
Automatically inform Revise of stdlibs in test suite (#38450)
This doesn't make PRs like timholy/Revise.jl#522, timholy/Revise.jl#534, timholy/Revise.jl#553, etc unnecessary since that will still be required if you want to revise a stdlib while working normally from the REPL, but this at least makes a quick `make test-revise-complex` to work where you're trying out unrelated changes to the as-yet unknown standard libraries. Before: ```julia $ make test-revise-complex JULIA test/revise-complex ERROR: LoadError: no Revise.track recipe for module NetworkOptions Stacktrace: [1] error(::String, ::Symbol) @ Base ./error.jl:42 [2] _track(id::Base.PkgId, modname::Symbol; modified_files::Set{Tuple{Revise.PkgData, String}}) @ Revise ~/.julia/packages/Revise/fwStr/src/recipes.jl:105 ... ``` After: ```julia $ make test-revise-complex JULIA test/revise-complex WARNING: redefinition of constant _clipboard_copy. This may fail, cause incorrect answers, or produce other errors. WARNING: redefinition of constant _clipboard_paste. This may fail, cause incorrect answers, or produce other errors. ┌ Warning: skipping callee #wait#19 (called by wait) due to UndefVarError(:WindowsRawSocket) └ @ LoweredCodeUtils ~/.julia/packages/LoweredCodeUtils/cquzG/src/signatures.jl:279 Test (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB) complex (1) | started at 2020-11-15T12:06:27.051 complex (1) | 17.83 | 0.29 | 1.6 | 1338.02 | 592.97 Test Summary: | Pass Broken Total Overall | 8410 5 8415 SUCCESS ```
1 parent 03c7d6c commit 377aa80

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/runtests.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ tests = unique(tests)
1515

1616
if use_revise
1717
using Revise
18+
union!(Revise.stdlib_names, Symbol.(STDLIBS))
1819
# Remote-eval the following to initialize Revise in workers
1920
const revise_init_expr = quote
2021
using Revise
2122
const STDLIBS = $STDLIBS
23+
union!(Revise.stdlib_names, Symbol.(STDLIBS))
2224
revise_trackall()
2325
end
2426
end

0 commit comments

Comments
 (0)