Skip to content

Commit 0b1b5f7

Browse files
authored
Disarm watchdog timer at the end of the Sockets test (#38586)
The Sockets test sets up a time bomb to go off after 10 minutes (intended to give a backtrace if the Sockets test hangs), but never disarms it, so it often just blows up whatever hapless test happens to come after it.
1 parent 0f427e1 commit 0b1b5f7

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

stdlib/Sockets/test/runtests.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function killjob(d)
2121
ccall(:uv_kill, Cint, (Cint, Cint), getpid(), Base.SIGTERM)
2222
nothing
2323
end
24-
Timer(t -> killjob("KILLING BY SOCKETS TEST WATCHDOG\n"), 600)
24+
sockets_watchdog_timer = Timer(t -> killjob("KILLING BY SOCKETS TEST WATCHDOG\n"), 600)
2525

2626
@testset "parsing" begin
2727
@test ip"127.0.0.1" == IPv4(127,0,0,1)
@@ -617,3 +617,6 @@ end
617617
end
618618
end
619619
end
620+
621+
622+
close(sockets_watchdog_timer)

0 commit comments

Comments
 (0)