-
-
Notifications
You must be signed in to change notification settings - Fork 275
[release-1.6] Add manifest julia_version difference warning #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
IanButterworth
merged 4 commits into
JuliaLang:release-1.6
from
IanButterworth:ib/16_manifest_julia_version_warning
Feb 1, 2022
Merged
[release-1.6] Add manifest julia_version difference warning #2666
IanButterworth
merged 4 commits into
JuliaLang:release-1.6
from
IanButterworth:ib/16_manifest_julia_version_warning
Feb 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
628c802
to
c25ef2b
Compare
I think this is a bit too late to go into 1.6.2 but could go into 1.6.3. |
Fair |
Is this good to go? So we can get it into the next 1.6.x? |
c25ef2b
to
f4da279
Compare
Can we get this into 1.6.6? |
I think that's a good idea. Just added some tests. |
To illustrate with this Manifest.toml 1.6.5
This PR on 1.6.5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2665 I think it would be helpful for 1.6.2 to have something like this. Otherwise the user will get unactionable errors with no warning.
This is a 1.6-appropriate modification of the warning that was omitted in #2620 when backported in #2628