Skip to content

fix: add BLAS.geru! manual doc #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2025
Merged

Conversation

hz-xiaxz
Copy link
Contributor

@hz-xiaxz hz-xiaxz commented Jul 5, 2025

closes #1401

Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (67c1103) to head (d9a8811).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1402   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          34       34           
  Lines       15827    15827           
=======================================
  Hits        14855    14855           
  Misses        972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch
Copy link
Member

I think the comment is like a placeholder, like a to-do, that you have just done. ;-) You could remove that line.

@hz-xiaxz
Copy link
Contributor Author

hz-xiaxz commented Jul 5, 2025

Yes but I found similar patterns here, https://github.com/JuliaLang/LinearAlgebra.jl/blob/67c1103e350bcce0ecc0c92a25ceac148e14b399/src/blas.jl#L53C4-L57C10, not sure why geru! is missing. I would fix it.

@ViralBShah ViralBShah merged commit 9e2ed1c into JuliaLang:master Jul 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLAS.geru! doc is missing
4 participants