Refactor node-specific flags to overlap with numeric flags #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves node-specific flags (TRIPLE_STRING_FLAG, PARENS_FLAG, etc.) from bits 5-6 to overlap with numeric flags in bits 8-15. This is safe because: 1. Node types that use specific flags never use numeric flags 2. Numeric flags are only used by ncat/nrow nodes, which don't use node-specific flags 3. The parser now passes dimensions separately to avoid flag conflicts Key changes: - Moved most node-specific flags to bit 8, some to bit 9 - Refactored parse_cat/parse_array to return dimension as a separate value - Updated emit_braces to accept dimension parameter - Made untokenize function head-aware for proper flag display - Simplified flag handling by removing conditionals (just OR flags together) - Added tests for dimension 4 ncat to ensure higher dimensions work correctly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 95.56% 94.79% -0.78%
==========================================
Files 15 15
Lines 4441 4225 -216
==========================================
- Hits 4244 4005 -239
- Misses 197 220 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #567, this change moves node-specific flags (TRIPLE_STRING_FLAG, PARENS_FLAG, etc.) from bits 5-6 to overlap with numeric flags in bits 8-15. This is safe because:
This solves the problem of running out of flags space for now, but there still is a concern that we may want to tweak the representation for easy of macro manipulation. As discussed in #567, I think we should wait on that until we have some more actual code to decide on APIs. However, these changes should help in any case, since they split out the dim and the flags argument until the last moment.