Hashing fixup, equality support, and serialization support #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 6, 2024
Closed
LilithHafner
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 95.83% 95.84%
=======================================
Files 13 13
Lines 3937 3946 +9
=======================================
+ Hits 3773 3782 +9
Misses 164 164 ☔ View full report in Codecov by Sentry. |
Closed
aviatesk
added a commit
that referenced
this pull request
Jun 5, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
added a commit
that referenced
this pull request
Jun 5, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
added a commit
that referenced
this pull request
Jun 5, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
added a commit
that referenced
this pull request
Jun 5, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
added a commit
that referenced
this pull request
Jun 5, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
aviatesk
added a commit
that referenced
this pull request
Jun 7, 2025
This optimizes the `hash` implementation added in #452. Creating tuples with statically unknown types that may hold random values at runtime should be avoided for performance reasons. As a result, the allocation regression reported in #558 has been reduced to the previous level, although the time regression from `hash` calculation still remains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need these helper functions to facilitate checking if a string parses the same way on different versions of JuliaSyntax. They're generally useful/bugfixes/implement missing functionality that should be expected, so I figure I'll include them in
src.Fixes #449 - a hash-== mismatch bug
Implements #450 - supports equality on
SyntaxNodeImplements #451 - supports serialization by implementing
readandwriteonKind. I used strings instead of UInt16 to represent Kind, see inline comment for more info.