-
Notifications
You must be signed in to change notification settings - Fork 60
REPL completion fix on 1.12 #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 85.51% 85.35% -0.17%
==========================================
Files 26 26
Lines 1712 1727 +15
==========================================
+ Hits 1464 1474 +10
- Misses 248 253 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -137,22 +136,31 @@ mutable struct RCompletionProvider <: LineEdit.CompletionProvider | |||
end | |||
|
|||
# Julia PR #54311 (backported to 1.11) added the `hint` argument | |||
if v"1.11.0-beta1.46" <= VERSION < v"1.12.0-DEV.0" || VERSION >= v"1.12.0-DEV.468" | |||
@static if v"1.11.0-beta1.46" <= VERSION < v"1.12.0-DEV.0" || VERSION >= v"1.12.0-DEV.468" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is @static
needed?
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Looks like multiple causes. Additional bisection leads to:
|
Multiple sources of breakage
LineEditREPL
since moving hints to worker thread JuliaLang/julia#58189