Skip to content

REPL completion fix on 1.12 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

REPL completion fix on 1.12 #569

wants to merge 16 commits into from

Conversation

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (5677359) to head (a09b32d).

Files with missing lines Patch % Lines
src/RPrompt.jl 88.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   85.51%   85.35%   -0.17%     
==========================================
  Files          26       26              
  Lines        1712     1727      +15     
==========================================
+ Hits         1464     1474      +10     
- Misses        248      253       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj mentioned this pull request Apr 18, 2025
@@ -137,22 +136,31 @@ mutable struct RCompletionProvider <: LineEdit.CompletionProvider
end

# Julia PR #54311 (backported to 1.11) added the `hint` argument
if v"1.11.0-beta1.46" <= VERSION < v"1.12.0-DEV.0" || VERSION >= v"1.12.0-DEV.468"
@static if v"1.11.0-beta1.46" <= VERSION < v"1.12.0-DEV.0" || VERSION >= v"1.12.0-DEV.468"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is @static needed?

@palday
Copy link
Collaborator Author

palday commented Apr 22, 2025

Looks like multiple causes. Additional bisection leads to:

0b9525bf81a1727e18d3342a6da7f8505bc447f5 is the first bad commit
commit 0b9525bf81a1727e18d3342a6da7f8505bc447f5
Author: Ian Butterworth <i.r.butterworth@gmail.com>
Date:   Fri Jan 31 12:08:26 2025 -0500

    REPL: generate tab completion hints on a worker thread to not block typing (#57192)

 stdlib/REPL/src/LineEdit.jl | 110 +++++++++++++++++++++++++++++---------------
 stdlib/REPL/src/REPL.jl     |  10 ++--
 2 files changed, 79 insertions(+), 41 deletions(-)

JuliaLang/julia#57192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants