Skip to content

Move GeoInterface.jl to an extension #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

rafaqz
Copy link
Contributor

@rafaqz rafaqz commented Jul 5, 2025

Revives #212 but for more recent changes here

Removing the GeoInterface dependency is actually crucial to simplifying GeoInterface plotting dependencies and Makie 0.24, because currently GeoInterface cant extend anything that depends on GeometryBasics.jl because of the circularity (i.e. it will break precompilation).

(there is some chance there will be circularity between extensions somewhere anyway after this, but lets deal with that later, and avoid the more drastic #260 option for now)

@SimonDanisch this is the start of getting rid of GeoInterfaceMakie.jl ;)

@rafaqz
Copy link
Contributor Author

rafaqz commented Jul 5, 2025

I dropped Julia 1.6 and set the minimum compat to 1.10, so that extensions work

@rafaqz
Copy link
Contributor Author

rafaqz commented Jul 5, 2025

The documenter issue is just xvfb, not this PR:

  DISPLAY=:0 xvfb-run -s '-screen 0 1024x768x24' julia --project=docs docs/make.jl
  shell: /usr/bin/bash -e {0}
  env:
    JULIA_PKG_SERVER: 
    GITHUB_TOKEN: ***
    DOCUMENTER_KEY: 
xvfb-run: error: Xvfb failed to start
Error: Process completed with exit code 1.

@asinghvi17
Copy link
Contributor

I reran the doc build, seems to pass.

@SimonDanisch
Copy link
Member

Thank you! <3
I guess we want to tag this as a breaking version? Or, now that it's an extension, we can do it in a patch release?
Although I think registrator expects dropping a julia version to be tagged as breaking...

@asinghvi17
Copy link
Contributor

asinghvi17 commented Jul 7, 2025

I think registrator should be fine? At least I have never had that experience.

This isn't actually breaking, all the functionality still exists, it's just in an extension now. The only potentially breaking thing might be people using GeometryBasics.GeoInterface but I don't imagine many people were doing that...

And better to do that in a patch release so folks can use older versions of GB on older versions of Julia

@SimonDanisch SimonDanisch merged commit e99d96f into JuliaGeometry:master Jul 7, 2025
23 of 24 checks passed
@rafaqz rafaqz deleted the geointerface_ext branch July 7, 2025 15:11
@rafaqz
Copy link
Contributor Author

rafaqz commented Jul 7, 2025

Yeah, accessing internals like that is their problem. I think this shouldn't be breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants