Move GeoInterface.jl to an extension #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #212 but for more recent changes here
Removing the GeoInterface dependency is actually crucial to simplifying GeoInterface plotting dependencies and Makie 0.24, because currently GeoInterface cant extend anything that depends on GeometryBasics.jl because of the circularity (i.e. it will break precompilation).
(there is some chance there will be circularity between extensions somewhere anyway after this, but lets deal with that later, and avoid the more drastic #260 option for now)
@SimonDanisch this is the start of getting rid of GeoInterfaceMakie.jl ;)