Fix incircle issuees #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't imagine that test failure on 1.8 has anything to do with this PR? |
|
That appears to be a JET failure, so not related to this PR. This looks good, thanks for it! |
|
Did you intend to merge this with your comment @dgleich? |
|
Thanks for the nudge. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20. I didn't change the
incirclemethod to the one I implemented at JuliaGeometry/AdaptivePredicates.jl#21 but I fixed the conditions for allocating (see the issue). I also fixed theinboundsissues by porting over the new versions of the arithmetic functions I implemented at AdaptivePredicates.jl. Thesafe_getindexis necessary unfortunately, even early into the function.JuliaGeometry/AdaptivePredicates.jl#21 gives some benchmarks with this approach to show that the speed is still good.