Add all the remaining #define
macros from predicates.c
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining arithmetic functions still need to be added but here I've added all the remaining
#define
macros.#define
macros as functions in C so that we can get them through@ccall
. I tested my conversions in C inmacro_defs.c
. I've pretty much never used C (only one other time for ~20 minutes before looking into this PR) so my C code is probably very rough.@ccall
. For some reason the only one not exactly correct all the time isTwo_Square
. I don't know why exactly...I restructured the code a bit to help organise it better when I later add the remaining functions.
(The point here being of course that I'm trying to get all the macros/arithmetic functions in and tested so I can port over the remaining predicates)