Skip to content

Remove unneedded line in oneArray constructor #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

christiangnrd
Copy link
Member

It seems like this was accidentally left in?

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/array.jl b/src/array.jl
index edc6b44..23ac079 100644
--- a/src/array.jl
+++ b/src/array.jl
@@ -68,7 +68,7 @@ mutable struct oneArray{T,N,B} <: AbstractGPUArray{T,N}
         end
     end
     obj = new{T,N,B}(data, maxsize, 0, dims)
-    finalizer(unsafe_free!, obj)
+        return finalizer(unsafe_free!, obj)
   end
 
   function oneArray{T,N}(data::DataRef{B}, dims::Dims{N};

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (28d7eed) to head (281dc0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   81.86%   81.89%   +0.03%     
==========================================
  Files          44       44              
  Lines        2531     2530       -1     
==========================================
  Hits         2072     2072              
+ Misses        459      458       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt merged commit 0622384 into JuliaGPU:master May 13, 2025
2 checks passed
@christiangnrd christiangnrd deleted the patch-1 branch May 13, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants