Skip to content

Make package loadable on macOS #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Feb 26, 2025

I verified this fixes #489:

julia> using oneAPI
┌ Error: No oneAPI Level Zero loader found for your platform. Currently, only Linux x86 is supported.
│ If you have a local oneAPI toolchain, you can use that; refer to the documentation for more details.
└ @ oneAPI.oneL0 ~/.julia/packages/oneAPI/8uwwt/lib/level-zero/oneL0.jl:118

julia> 

The message is only an @error logging, but the session is otherwise fully functional.

CC: @vchuravy. PR best reviewed by ignoring whitespace changes.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (1c34336) to head (3724302).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/oneAPI.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   81.85%   81.86%   +0.01%     
==========================================
  Files          44       44              
  Lines        2529     2531       +2     
==========================================
+ Hits         2070     2072       +2     
  Misses        459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy merged commit 5971392 into JuliaGPU:master Feb 26, 2025
2 checks passed
@giordano giordano deleted the mg/load-macos branch February 26, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing on Mac gives an error that halts the session
2 participants