Skip to content

avoid boxing when @kernel is used as a closure #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-0.9
Choose a base branch
from
Open

avoid boxing when @kernel is used as a closure #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/macros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,10 @@ function __kernel(expr, generate_cpu = true, force_inbounds = false, unsafe_indi
gpu_function = combinedef(def_gpu)

# create constructor functions
_name = Symbol(:_, name)
constructors = quote
if $(name isa Symbol ? :(!@isdefined($name)) : true)
Core.@__doc__ $name(dev) = $name(dev, $DynamicSize(), $DynamicSize())
$name(dev, size) = $name(dev, $StaticSize(size), $DynamicSize())
$name(dev, size, range) = $name(dev, $StaticSize(size), $StaticSize(range))
function $name(dev::Dev, sz::S, range::NDRange) where {Dev, S <: $_Size, NDRange <: $_Size}
function $_name(dev::Dev, sz::S, range::NDRange) where {Dev, S <: $_Size, NDRange <: $_Size}
if $isgpu(dev)
return $construct(dev, sz, range, $gpu_name)
else
Expand All @@ -66,6 +64,10 @@ function __kernel(expr, generate_cpu = true, force_inbounds = false, unsafe_indi
end
end
end
Core.@__doc__ $name(dev) = $_name(dev, $DynamicSize(), $DynamicSize())
$name(dev, size) = $_name(dev, $StaticSize(size), $DynamicSize())
$name(dev, size, range) = $_name(dev, $StaticSize(size), $StaticSize(range))
$name(dev, size::$_Size, range::$_Size) = $_name(dev, size, range)
end
end

Expand Down
15 changes: 15 additions & 0 deletions test/test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,5 +349,20 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk
end
end

@testset "`@kernel` as a closure" begin
function foo()
@kernel function kernel(A)
i = @index(Global)
A[i] = 1
end
return kernel
end
ftypes = fieldtypes(typeof(foo()))
@test !any(T -> T <: Core.Box, ftypes)
@test all(ftypes) do T
!any(T -> T <: Core.Box, fieldtypes(T))
end
end

return
end
Loading