Skip to content

Local correlation dimension #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Local correlation dimension #38

merged 5 commits into from
Oct 31, 2024

Conversation

Datseris
Copy link
Member

No description provided.

@Datseris
Copy link
Member Author

@PythagoreanCult Can you add a test here? Or, just test this function with some example set of points and confirm that it does what we expect?

@Datseris
Copy link
Member Author

@PythagoreanCult please don't approve PRs without actually testing them. I just wrote a test for the code and it doesn't run. It errors:

      
ERROR: UndefVarError: `Eucliean` not defined
Stacktrace:
 [1] local_correlation_sum(X::StateSpaceSet{2, Float64, SVector{2, Float64}}, ζ::SVector{2, Float64}, k::Int64)
   @ FractalDimensions C:\Users\datse\.julia\dev\FractalDimensions\src\corrsum_based\correlationsum_vanilla.jl:245
 [2] local_correlation_dimension(::StateSpaceSet{…}, ::Vararg{…}; fit::LinearRegression, kw::@Kwargs{})
   @ FractalDimensions C:\Users\datse\.julia\dev\FractalDimensions\src\corrsum_based\correlationsum_vanilla.jl:240
 [3] local_correlation_dimension(::StateSpaceSet{2, Float64, SVector{2, Float64}}, ::Vararg{Any})
   @ FractalDimensions C:\Users\datse\.julia\dev\FractalDimensions\src\corrsum_based\correlationsum_vanilla.jl:239

there are several typos. Next time please write and run an actual test before approving or not approve at all if you are out of time. For now I've written and pushed a test here so we're all good.

@Datseris Datseris merged commit 65c69de into main Oct 31, 2024
2 checks passed
@Datseris Datseris deleted the pointwise branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants