Skip to content

CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ForwardDiff package from 0.10 to 0.10, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (633dd46) to head (6d2cee6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          18       18           
  Lines        1586     1586           
=======================================
  Hits         1308     1308           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion
Copy link
Member

The ArrayFunction... test failures on Julia 1.11 are the same as on the master branch but there are a few new test failures (related to acosh it seems). Those resemble test failures on ForwardDiff#master so it is possible that they are introduced here due to ForwardDiff 1.

@devmotion
Copy link
Member

Not ideal, of course, but https://github.com/JuliaDiff/ReverseDiff.jl/actions/runs/14131137700/job/39591493233?pr=272 confirms that the test errors on Julia 1.11 are not introduced by ForwardDiff 1 but already exist on the master branch.

@devmotion devmotion merged commit 90f1516 into master Mar 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant