Skip to content

Remove Composite Bundle #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 26, 2023
Merged

Remove Composite Bundle #216

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7c0641c
rename testset
oxinabox Sep 19, 2023
be091aa
Initial pass at switching CompositeBundle over to TaylorTangentBundle
oxinabox Sep 19, 2023
c205e34
Remove most uses of CompositeTangent
oxinabox Sep 19, 2023
cf137a0
fix sin_twice_fwd test
oxinabox Sep 20, 2023
13762e7
Remove check that if primal is TangentBundle so is coeff
oxinabox Sep 20, 2023
f4f996d
remove condition on getindex overload
oxinabox Sep 20, 2023
50383b6
Port over shuffle_up
oxinabox Sep 20, 2023
bfd99c2
Port map special handling
oxinabox Sep 20, 2023
121ec20
port remaining ∂☆ overloads to TaylorTangent
oxinabox Sep 20, 2023
b257eeb
Fix/update version check on if to define getindex(ir,ssa)
oxinabox Sep 20, 2023
b9f74ce
use i
oxinabox Sep 21, 2023
34cedf8
remove redudant interpolation
oxinabox Sep 21, 2023
9794666
fix and test taylor_compatible
oxinabox Sep 21, 2023
ba5841e
remove excess whitepace
oxinabox Sep 26, 2023
40da34b
fix missing imports
oxinabox Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/tangent.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,13 @@ end
const TaylorBundle{N, B, P} = TangentBundle{N, B, TaylorTangent{P}}

function TaylorBundle{N, B}(primal::B, coeffs) where {N, B}
# check_taylor_invariants(coeffs, primal, N) # TODO: renable this
check_taylor_invariants(coeffs, primal, N)
_TangentBundle(Val{N}(), primal, TaylorTangent(coeffs))
end

function check_taylor_invariants(coeffs, primal, N)
@assert length(coeffs) == N
if isa(primal, TangentBundle)
@assert isa(coeffs[1], TangentBundle)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check is just wrong AFAICT.
because if the primal is a TangentBundle, then the first derivative is a Tangent{TangentBundle}
The first deriviative has no primal component.

But this was never hit before because we were not making TaylorBundles when taking derivatives of TaylorBundles, (at least not in anything that happens in our test/forward.jl I checked) we were (I assume) making CompositeBundles

end

end
@ChainRulesCore.non_differentiable check_taylor_invariants(coeffs, primal, N)

Expand Down