Skip to content

feat!: specify preparation arguments in DIT Scenario #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 11, 2025
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented May 9, 2025

Warning

Breaking changes in DifferentiationInterfaceTest

Breaking

  • Change Scenario type and constructors:
    • Rename tang field to t
    • Remove smaller field
    • Add prep_args named tuple field containing (; x, [t,] contexts) or (; y, x, [t,] contexts)
  • Change scenario constructors to accept positional arguments in the same order as the differentiation operators

Not breaking

  • Replace random preparation values with zero preparation values to intialize prep_args, remove myzero
  • Use prep_args in correctness, benchmark and type stability tests
  • Resize preparation during correctness tests when the sizes exist and don't match between scen.x and scen.prep_args.x (resp. y)
  • Add include_smaller kwarg to default_scenarios
  • Test smaller scenarios only for ForwardDiff, FiniteDiff and core tests

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (c2bd64f) to head (d970daf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   97.84%   97.84%   -0.01%     
==========================================
  Files         128      128              
  Lines        7707     7693      -14     
==========================================
- Hits         7541     7527      -14     
  Misses        166      166              
Flag Coverage Δ
DI 98.68% <100.00%> (-0.24%) ⬇️
DIT 95.61% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle linked an issue May 9, 2025 that may be closed by this pull request
@gdalle gdalle marked this pull request as ready for review May 11, 2025 21:08
@gdalle gdalle added the skipci Don't run CI tests and docs label May 11, 2025
@gdalle gdalle merged commit d2e12ae into main May 11, 2025
1 of 2 checks passed
@gdalle gdalle deleted the gd/prepdit branch May 11, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skipci Don't run CI tests and docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specific preparation values for DifferentiationInterfaceTest.Scenarios
1 participant