Skip to content

Julia 1.6 compat #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
May 6, 2024
Merged

Julia 1.6 compat #243

merged 47 commits into from
May 6, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented May 2, 2024

Make everything compatible with Julia 1.6

  • Add Compat.jl and PackageExtensionCompat.jl to dependencies
  • Use PackageExtensionCompat.jl to do Requires.jl on all extensions
  • Use stack freely because it is Compat.stack
  • Replace destructuring (; x, y) = obj with @compat (; x, y) = obj
  • Replace @kwdef with Base.@kwdef
  • Widen compat bounds
  • Make JET, Aqua and JuliaFormatter stuff conditional on VERSION >= v"1.10"
  • Pkg shenanigans to get around the fact that no registered version of DI / DIT is 1.6 compatible yet (that's the fucking point)
  • Install the backends in the test code itself for DI, in two batches depending on 1.6 compat

Only FiniteDifferences, ForwardDiff, ReverseDiff, Tracker and Zygote are tested on 1.6

This is a bit hard with every backend at once: we need to figure out how to split the tests

See also this problem with stdlib compat:

@gdalle gdalle marked this pull request as draft May 2, 2024 23:32
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 99.46809% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.43%. Comparing base (571133f) to head (0b862db).

Files Patch % Lines
...onInterfaceChainRulesCoreExt/differentiate_with.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   95.32%   95.43%   +0.10%     
==========================================
  Files          74       74              
  Lines        3936     3942       +6     
==========================================
+ Hits         3752     3762      +10     
+ Misses        184      180       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review May 6, 2024 17:11
@gdalle gdalle merged commit db908fb into main May 6, 2024
6 checks passed
@gdalle gdalle deleted the gd/16 branch May 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants