Merge pull request #230 from dfdx/dfdx/fix-test-broadcasted

Fix test_approx() when one of the arguments is a broadcasted multidimensional array

Author: oxinabox

.gitignore

@@ -27,3 +27,6 @@ docs/site/
 
 # JetBrains meta files
 .idea/*
+
+# VS Code meta files
+.vscode/

src/check_result.jl

@@ -142,8 +142,9 @@ function test_approx(actual::A, expected::E, msg=""; kwargs...) where {A,E}
     if _can_pass_early(actual, expected)
         @test true
     else
-        c_actual = collect(actual)
-        c_expected = collect(expected)
+        # Works around https://github.com/JuliaLang/julia/issues/43847 on pre-Julia v1.9
+        c_actual = collect(Broadcast.materialize(actual))
+        c_expected = collect(Broadcast.materialize(expected))
         if (c_actual isa A) && (c_expected isa E)  # prevent stack-overflow
             throw(MethodError, test_approx, (actual, expected))
         end

test/check_result.jl

@@ -36,6 +36,7 @@ end
 
             test_approx([1.0, 2.0], [1.0, 2.0])
             test_approx([[1.0], [2.0]], [[1.0], [2.0]])
+            test_approx(Broadcast.broadcasted(identity, [1.0 2.0; 3.0 4.0]), [1.0 2.0; 3.0 4.0])
 
             test_approx(@thunk(10 * 0.1 * [[1.0], [2.0]]), [[1.0], [2.0]])