Skip to content

Commit 5e5acf8

Browse files
committed
Explain the need for Broadcast.materialize in tester
1 parent d34a524 commit 5e5acf8

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,6 @@ docs/site/
2727

2828
# JetBrains meta files
2929
.idea/*
30+
31+
# VS Code meta files
32+
.vscode/

src/check_result.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ function test_approx(actual::A, expected::E, msg=""; kwargs...) where {A,E}
142142
if _can_pass_early(actual, expected)
143143
@test true
144144
else
145+
# Works around https://github.com/JuliaLang/julia/issues/43847 on pre-Julia v1.9
145146
c_actual = collect(Broadcast.materialize(actual))
146147
c_expected = collect(Broadcast.materialize(expected))
147148
if (c_actual isa A) && (c_expected isa E) # prevent stack-overflow

0 commit comments

Comments
 (0)