Skip to content

Minor tidy: use peel rather than [1] and drop #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Oct 8, 2021

Very small change as a follow up to something changed in #482
Since we want the head and the tail, we can use Iterators.peel

Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bump and it's good to fly

@oxinabox
Copy link
Member Author

oxinabox commented Oct 8, 2021

version bump and it's good to fly

It is a nonfunctional change.

@oxinabox oxinabox merged commit 695dd77 into master Oct 8, 2021
@oxinabox oxinabox deleted the ox/peelnotdrop branch October 8, 2021 12:20
@mzgubic
Copy link
Member

mzgubic commented Oct 8, 2021

Sure, but it could inadvertently introduce a bug. My understanding was that any change to code src/ should bump a version?

@oxinabox
Copy link
Member Author

oxinabox commented Oct 8, 2021

For small nonfunctional changes I am ambivalent. We've run tests and reverse dep tests.
For bigger refactorings I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants