Make levels return a CategoricalArray
#425
Open
+135
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `levels` preserve the eltype of the input is sometimes useful to write generic code. This is only slightly breaking as the result still compares equal to the previous behvior returning unwrapped values.
bkamins
approved these changes
May 27, 2025
|
Further to my posts at #390, I have run MLJ integration tests against this branch of CategoricalArrays.jl. Only two models fail, both provided by the package BetaML.jl: "PegasosClassifier (BetaML)", "PerceptronClassifier (BetaML)" I will investigate further shortly and report back here. cc @sylvaticus I have separately tested CategoricalDistributions, MLJModelInterface, and MLJBase, against this branch, with no fails. |
|
I'll too have a look, but I need a few days.... |
|
Thanks. In parallel, let's try whether Nanosoldier can check all direct dependencies: |
|
Better check against current release: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
levelspreserve the eltype of the input is sometimes useful to write generic code. This is only slightly breaking as the result still compares equal to the previous behvior returning unwrapped values.Fixes #390.