Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
permissions: # needed for julia-actions/cache to delete old caches
actions: write
contents: read
continue-on-error: ${{ matrix.version == 'pre' }} # the CI badge will still pass if 'pre' fails
continue-on-error: ${{ matrix.version == 'pre' || matrix.version == 'nightly' }} # the CI badge will still pass if 'pre' or 'nightly' fails
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why I added this line. The failure on pre will be ignored in the final CI results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the icons below can be misleading since there is a big red X on pre. The CI badges will still be green howeve, as far as I know.

This is an issue with GitHub actions, the allow-failure setting does not exist for now actions/runner#2347

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -53,7 +53,6 @@ jobs:
- uses: julia-actions/julia-runtest@v1
env:
GROUP: ${{ matrix.group }}
# continue-on-error: ${{ matrix.version == 'nightly' }} # Allow nightly to fail and workflow still count as completed
- uses: julia-actions/julia-processcoverage@v1
with:
directories: src,lib/ControlSystemsBase/src,lib/ControlSystemsBase/ext
Expand Down
Loading