Skip to content

Fix typos in comments #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix typos in comments #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c806df
Update ReputationMiningCycleBinarySearch.sol
leopardracer Apr 22, 2025
d9856f8
Update ReputationMiningCycleRespond.sol
leopardracer Apr 22, 2025
508a4eb
Update ReputationMiner.js
leopardracer Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/reputationMiningCycle/ReputationMiningCycleBinarySearch.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ contract ReputationMiningCycleBinarySearch is ReputationMiningCycleCommon {
uint256 expectedLength = expectedProofLength(
submission.jrhNLeaves,
disputeRounds[_round][_idx].lowerBound
) - (disputeRounds[_round][_idx].challengeStepCompleted - 1); // We expect shorter proofs the more chanllenge rounds we've done so far
) - (disputeRounds[_round][_idx].challengeStepCompleted - 1); // We expect shorter proofs the more challenge rounds we've done so far
require(
expectedLength == _siblings.length,
"colony-reputation-mining-invalid-binary-search-proof-length"
Expand Down
2 changes: 1 addition & 1 deletion contracts/reputationMiningCycle/ReputationMiningCycleRespond.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ contract ReputationMiningCycleRespond is ReputationMiningCycleCommon {
}

function confirmChallengeCompleted(uint256[26] memory _u) internal {
// If everthing checked out, note that we've responded to the challenge.
// If everything checked out, note that we've responded to the challenge.
disputeRounds[_u[U_ROUND]][_u[U_IDX]].challengeStepCompleted += 1;
disputeRounds[_u[U_ROUND]][_u[U_IDX]].lastResponseTimestamp = block.timestamp;
Submission storage submission = reputationHashSubmissions[
Expand Down
2 changes: 1 addition & 1 deletion packages/reputation-miner/ReputationMiner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ class ReputationMiner {

// When reputation amount update is negative, adjust its value for child reputation updates and parent updates
// We update colonywide sums first (children, parents, skill)
// Then the user-specifc sums in the order children, parents, skill.
// Then the user-specific sums in the order children, parents, skill.
if (amount.lt(0)) {
const nUpdates = ethers.BigNumber.from(logEntry.nUpdates);
const [nParents] = await this.colonyNetwork.getSkill(logEntry.skillId, {blockTag: blockNumber});
Expand Down