Array slice sample #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsw
reviewed
Jan 15, 2024
| @@ -0,0 +1,137 @@ | |||
| An array is a numbered, fixed-size sequence of elements of a single [type](link to type spec), called the element type. The element type of an array can be any Rust [type](link to type spec). | |||
There was a problem hiding this comment.
Does the size of the element type of an array need to be known at compile time? I am not sure that this is even applicable, but I thought that I would note it.
There was a problem hiding this comment.
cf https://spec.ferrocene.dev/types-and-traits.html#syntax_arraytypespecification
The [element type](https://spec.ferrocene.dev/glossary.html#term_element_type) shall be a [fixed sized type](https://spec.ferrocene.dev/glossary.html#term_fixed_sized_type).
where it says that the element type needs to have a fixed size.
specification/arrays.md
Outdated
|
|
||
| If the array is mutable, as defined by the `mut` keyword, the array elements can be updated. The size and type of the array can never change. | ||
|
|
||
| Updating the value of an array element is performed by specifying the index of the element to be changed and setting it to the new value. |
There was a problem hiding this comment.
Would we want assignment like this to automatically invoke an Into::into upon assignment if the type of elements of the array are different than the value in the assignment?
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Co-authored-by: Will Hawkins <whh8b@obs.cr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.