-
Notifications
You must be signed in to change notification settings - Fork 296
Remove some non-determinism #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/ We can fix the GO BUILDID and the different /tmp paths.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Haha CLA, no, but you can take this as you please 😉 |
Thanks for the contribution. But unfortunately this PR won't make the app reproducible. Because to ensure a reproducible build, we need to use a fixed version of |
True, but I've tested this, and as the title says it's about "some" of it. :) Could this be made perfect? I hope so, in the mean time, this PR improves things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That sounds reasonable to me. Please accept the CLA so we can merge the PR.
As said, I won't submit to any CLA. :) |
Also, |
Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro
Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/
We can fix the GO BUILDID and the different /tmp paths.