Skip to content

Remove some non-determinism #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

licaon-kter
Copy link

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/

We can fix the GO BUILDID and the different /tmp paths.

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at the latest app report: https://verification.f-droid.org/packages/app.intra/

We can fix the GO BUILDID and the different /tmp paths.
Copy link

google-cla bot commented May 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@licaon-kter
Copy link
Author

Haha CLA, no, but you can take this as you please 😉

@jyyi1
Copy link
Contributor

jyyi1 commented May 27, 2025

Thanks for the contribution. But unfortunately this PR won't make the app reproducible. Because to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide the latest 0.0.0 version. This means that even if we fix the BUILDID, the produced binary isn't guaranteed to be reproducible.

@licaon-kter
Copy link
Author

True, but I've tested this, and as the title says it's about "some" of it. :)

Could this be made perfect? I hope so, in the mean time, this PR improves things.

Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That sounds reasonable to me. Please accept the CLA so we can merge the PR.

@licaon-kter
Copy link
Author

As said, I won't submit to any CLA. :)

@ignoramous
Copy link
Contributor

... to ensure a reproducible build, we need to use a fixed version of gomobile, but they only officially provide ... 0.0.0 ...

Also, gomobile driven builds don't yet respect -trimpath, at least not from what we've observed (from build of our Intra fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants