-
Notifications
You must be signed in to change notification settings - Fork 8
autmatic term mechanism for exercises #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good from my side. @FussballAndy, your thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would perhaps change the style s.t. instead of changing the entry of the dictionary we directly display the term and else display the value of info.term. Also the brackets around the conditions should be removed.
I.e.
if info.term == auto {
<display term accordingly>
} else {
info.term
}Note that this would currently also only make auto work in the exercise subline mode, but not submission. Though #21 could anyway potentially make this note redundant.
|
@FussballAndy done |
|
sorry it took so long, i kinda forgot about this PR. I fixed the brackets |
|
I will take a look next week and merge it then. |
|
Thanks! |
This PR adds the functionality to set the term to

autoinstead of a text, and it will resolve the current term automatically: