Skip to content

Conversation

@Rdeisenroth
Copy link
Contributor

This PR adds the functionality to set the term to auto instead of a text, and it will resolve the current term automatically:
image

@JeyRunner
Copy link
Owner

Looks good from my side. @FussballAndy, your thoughts?

Copy link
Contributor

@FussballAndy FussballAndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would perhaps change the style s.t. instead of changing the entry of the dictionary we directly display the term and else display the value of info.term. Also the brackets around the conditions should be removed.

I.e.

if info.term == auto {
  <display term accordingly>
} else {
  info.term
}

Note that this would currently also only make auto work in the exercise subline mode, but not submission. Though #21 could anyway potentially make this note redundant.

@Rdeisenroth
Copy link
Contributor Author

@FussballAndy done

@Rdeisenroth
Copy link
Contributor Author

sorry it took so long, i kinda forgot about this PR. I fixed the brackets

@JeyRunner
Copy link
Owner

I will take a look next week and merge it then.

@JeyRunner
Copy link
Owner

Thanks!

@JeyRunner JeyRunner merged commit b3c64aa into JeyRunner:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants