-
Notifications
You must be signed in to change notification settings - Fork 198
RG-2661 Replace the old loader with the new one #8941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hypnosphi
wants to merge
4
commits into
master
Choose a base branch
from
loader
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
94de264
RG-2661 Replace the old loader with the new one
Hypnosphi fffade0
RG-2661 Apply passed dom props to a common container instead of "squa…
Hypnosphi b8549fa
RG-2661 remove extra line
Hypnosphi 08b9407
RG-2661 make the animation GPU-only by animating only transform and o…
Hypnosphi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
packages/screenshots/testplane/chrome/components/loader/squares/squares-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
packages/screenshots/testplane/chrome/components/loader/squares/squares.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
packages/screenshots/testplane/firefox/components/loader/squares/squares-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
packages/screenshots/testplane/firefox/components/loader/squares/squares.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,21 @@ | ||
import {type StoryFn} from '@storybook/react-webpack5'; | ||
import {type StoryFn, type StoryObj} from '@storybook/react-webpack5'; | ||
|
||
import Loader, {type LoaderProps} from './loader'; | ||
|
||
export default { | ||
title: 'Components/Loader', | ||
|
||
component: Loader, | ||
parameters: { | ||
screenshots: {skip: true}, | ||
}, | ||
}; | ||
|
||
export const basic: StoryFn<LoaderProps> = args => <Loader {...args} />; | ||
|
||
basic.storyName = 'Loader'; | ||
basic.args = {message: 'Loading...'}; | ||
basic.parameters = { | ||
screenshots: {skip: true}, | ||
}; | ||
|
||
export const squares: StoryObj<LoaderProps> = { | ||
args: {message: 'Loading...', squares: true}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.