Skip to content

Take document scrollbar into account while calculating popup position… #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Take document scrollbar into account while calculating popup position… #8940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/popup/position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
getDocumentScrollLeft,
getDocumentScrollTop,
getRect,
getWindowHeight,
isMounted,
type Rect,
} from '../global/dom';
Expand Down Expand Up @@ -90,7 +89,7 @@ interface OverflowAttrs extends PositionAttrs {
}

function verticalOverflow(styles: PositionStyles, scrollingCoordinates: Position, attrs: OverflowAttrs) {
const containerHeight = attrs.container ? attrs.container.clientHeight : getWindowHeight();
const containerHeight = attrs.container ? attrs.container.clientHeight : document.documentElement.clientHeight;
const viewportMinX = scrollingCoordinates.top + attrs.sidePadding;
const viewportMaxX = scrollingCoordinates.top + containerHeight - attrs.sidePadding;

Expand All @@ -104,7 +103,7 @@ function verticalOverflow(styles: PositionStyles, scrollingCoordinates: Position
}

function horizontalOverflow(styles: PositionStyles, scrollingCoordinates: Position, attrs: OverflowAttrs) {
const containerWidth = attrs.container ? attrs.container.clientWidth : window.innerWidth;
const containerWidth = attrs.container ? attrs.container.clientWidth : document.documentElement.clientWidth;
const viewportMinY = scrollingCoordinates.left + attrs.sidePadding;
const viewportMaxY = scrollingCoordinates.left + containerWidth - attrs.sidePadding;

Expand Down