Skip to content

Conversation

Hypnosphi
Copy link
Contributor

No description provided.

use secondary color for empty select state, unless it's disabled
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Changes the color styling for empty select states from disabled color to secondary color, while preserving disabled color for disabled states. This improves visual hierarchy and readability by making empty selects more prominent than disabled ones.

Key changes:

  • Updated empty select color from disabled to secondary color
  • Added specific disabled styling for empty select states
  • Updated visual regression test screenshots to reflect color changes

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

File Description
src/select/select.css Updated color variables for empty select states and added disabled state handling
.storybook/preview.ts Removed select styles from color contrast issue selectors
packages/screenshots/* Updated visual regression test screenshots for both light and dark themes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Hypnosphi Hypnosphi requested a review from amanokh September 19, 2025 11:33
@Hypnosphi Hypnosphi enabled auto-merge (rebase) September 19, 2025 11:33
@Hypnosphi Hypnosphi marked this pull request as draft September 19, 2025 13:11
auto-merge was automatically disabled September 19, 2025 13:11

Pull request was converted to draft

@Hypnosphi Hypnosphi marked this pull request as ready for review September 19, 2025 13:22
@Hypnosphi Hypnosphi enabled auto-merge (rebase) September 19, 2025 13:22
@Hypnosphi Hypnosphi merged commit 3d4a4ed into master Sep 19, 2025
3 checks passed
@Hypnosphi Hypnosphi deleted the select-empty-color branch September 19, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants