refactor(eslint): RG-2636 Refactor ESLint config, enforce more strict rules #8879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanokh
force-pushed
the
amanokh/eslint-config
branch
from
36deb36 to
2d472f8
Compare
Hypnosphi
requested changes
Sep 15, 2025
Hypnosphi
approved these changes
Sep 15, 2025
amanokh
force-pushed
the
amanokh/eslint-config
branch
from
911f76e to
25ee3a4
Compare
amanokh
changed the title
Hypnosphi
reviewed
Sep 26, 2025
| this._data.push(sendingData); | ||
|
|
||
| if (this._flushMaxPackSize != null && this._data.length >= this._flushMaxPackSize) { | ||
| if (this._flushMaxPackSize && this._data.length >= this._flushMaxPackSize) { |
There was a problem hiding this comment.
I think flushMaxPackSize can be 0 as well
@amanokh can you please bring back the checks for null and undefined in all places where you removed it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was mainly changed:
languageOptionsname-of-component.utils.tsx) to filenames in /src===instead==, all occurrences of checking thevalue != nullwere changed either to!!valueorvalue !== null && value !== undefined(the second is for cases when the value could be an empty string or 0, this should be rewritten in future to use onlyundefinedfor types)