Skip to content

Conversation

Hypnosphi
Copy link
Contributor

The function value wasn't evaluated in Select classnames

@Hypnosphi Hypnosphi enabled auto-merge (rebase) September 12, 2025 18:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the controls height value wasn't being properly evaluated in the Select component's CSS class names. The fix extracts the height calculation logic into a reusable method to ensure consistent evaluation across the component.

Key Changes

  • Extracted height calculation logic into a private getHeight() method
  • Updated CSS class name generation to use the new method instead of inline evaluation
  • Applied the same height calculation fix to the _getIcons() method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Hypnosphi Hypnosphi requested a review from amanokh September 15, 2025 12:01
@Hypnosphi Hypnosphi merged commit 6dea735 into master Sep 15, 2025
4 checks passed
@Hypnosphi Hypnosphi deleted the select-height-usage branch September 15, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants