RG-2658 Change color scheme for toggle in Dark Theme #8866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the toggle color scheme for disabled states in the Dark Theme by refactoring CSS selector specificity and moving color properties to more appropriate selectors.
- Moved
--ring-toggle-item-colorfrom the unchecked disabled selector to the general disabled selector - Simplified CSS selector structure for better maintainability
- Updated visual regression test screenshots to reflect the new appearance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/toggle/toggle.css | Refactored disabled toggle styling by moving item color property to more general selector |
| packages/screenshots/testplane/firefox/components/toggle/toggle/toggle-dark.png | Updated Firefox visual regression test screenshot |
| packages/screenshots/testplane/chrome/components/toggle/toggle/toggle-dark.png | Updated Chrome visual regression test screenshot |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
amanokh
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RG-2658 Change color scheme for toggle in Dark Theme