Skip to content

Check release date on CI #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check release date on CI #488

wants to merge 3 commits into from

Conversation

tyranron
Copy link
Collaborator

I often catch myself that I forgot to update the release date in CHANGELOG once preparing a new release. So, I've added such check to CI in the projects I maintain. Would be useful here too, I guess.

@tyranron tyranron added this to the 2.1.0 milestone Jun 27, 2025
@tyranron tyranron self-assigned this Jun 27, 2025
@tyranron tyranron marked this pull request as ready for review June 27, 2025 13:16
@tyranron tyranron requested a review from JelteF June 27, 2025 13:19
@tyranron tyranron enabled auto-merge (squash) June 27, 2025 13:29
@tyranron
Copy link
Collaborator Author

ping @JelteF

@JelteF
Copy link
Owner

JelteF commented Jun 30, 2025

Afaict this will fail the github release creation if the date in the changelog is not today? I like that something checks for that, but when it checks seems like it's a bit too late. By then the tag has already been pushed and packages published.

@tyranron
Copy link
Collaborator Author

tyranron commented Jun 30, 2025

@JelteF yes, it checks when the Git tag is pushed, so if the date is incorrect, the GitHub release won't be created, and the tag could be re-applied to the next commit fixing it.

Regarding publishing to crates.io, it's usually done via CI in my projects. But as far as I recall, you were hesitant to that, to avoid leaking potential access to other your crates from this GitHub repo. Since then, crates.io added functionality for granular token access. It could be configured like this to not allow anything more:
Screenshot 2025-06-30 at 16 52 00

If you're not hesitant to this idea anymore, I can also add publishing via CI again, and do the changelog check before anything is published. Git tag, however, is the only thing to be reapplied if CI fails.

@tyranron
Copy link
Collaborator Author

tyranron commented Jul 1, 2025

@JelteF thoughts?

@tyranron
Copy link
Collaborator Author

tyranron commented Jul 7, 2025

@JelteF ping

@tyranron
Copy link
Collaborator Author

@JelteF we even can go now with the trusted publishing if you'd like, so there would be no need to generate a token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants