added new f1_ackermann_harmonic car and simple_circuit_harmonic.sdf world in ackermann_cars #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a launcher and a database entry for the world |
pariaspe
requested changes
Jun 27, 2025
CustomRobots/ackermann_cars/models/f1_renault_ackermann_harmonic/model.sdf
Outdated
Show resolved
Hide resolved
Hi @javizqh , Nikhil as part of his gsoc project is only in charge of migrating models and worlds (and not full exercise migration). Can we skip launcher and database entry creation (at least in this PR)? |
|
The database entry can be skipped, but the Launcher is needed to test that the car loads correctly. If you can test it with other methods it is fine without both. |
Resolving the reviews, corrected the model.sdf in f1_renault_ackermann_harmonic
nikhilg2603
force-pushed
the
humble-devel
branch
from
93353a4 to
acd7751
Compare
pariaspe
approved these changes
Jun 30, 2025
Tested locally and ackermann model is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with reference to issue #518. 3 files have been added, f1_ackermann_harmonic amd simple_circuit_harmonic package under the directory /CustomRobots/ackermann_cars/model. and simple_circuit_harmonic.sdf under the directory /CustomRobots/ackermann_cars/worlds.