Skip to content

Pulsar support for retry and DLQ #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Pulsar support for retry and DLQ #1333

wants to merge 31 commits into from
+1,064 −16

Conversation

punxrok
Copy link

@punxrok punxrok commented Mar 26, 2025

Pulsar support for retry and DLQ

punxrok and others added 12 commits March 25, 2025 13:26
@punxrok
Merge pull request #1 from JasperFx/main
55733ef 
3.11 update
JasperFx#1326 Pulsar support for native retry and DLQ queues - beware…
4014879 
… of ugly code
JasperFx#1326 Pulsar support for native retry and DLQ queues - beware…
e846db9 
… of ugly code
JasperFx#1326 Pulsar support for native retry and DLQ queues - beware…
0d14f9b 
… of ugly code
JasperFx#1326 Additional constructors for DeadLetterTopic and RetryLe…
9caf90d 
…tterTopic
JasperFx#1326 Additional constructors for DeadLetterTopic and RetryLe…
8dd8786 
…tterTopic
JasperFx#1326 Additional constructors for DeadLetterTopic and RetryLe…
42890d6 
…tterTopic
JasperFx#1326 refactoring
90ad042
JasperFx#1326 refactoring
ab74d4f
JasperFx#1326 fix
d0d1d8c
JasperFx#1326 refactoring for MoveToErrorsAsync
656daf0
JasperFx#1326 fix
f5f844e
@punxrok
Copy link
Author

punxrok commented Mar 27, 2025

Hey @jeremydmiller
can you please check #1333, especially the TODO: comments (like in PulsarListener.MoveToErrorsAsync(...)), where I would need some guidance.

@punxrok punxrok marked this pull request as ready for review March 31, 2025 13:04
JasperFx#1326 refactoring - as Jeremy suggested, I removed the action…
844c8b2 
… MoveToRetryLetterQueueAsync from the lifecycle
@jeremydmiller
Copy link
Member

@punxrok Couple things:

  • I'm concerned with how many files got touched here, and you introduced all new concepts into the core framework
  • How is the retry queue any different than Wolverine's existing re-queue mechanism? Why do we need an all new concept?
  • Why can't the DLQ fit into Wolverine's existing native DLQ abstractions? Why do we need all new abstractions just for Pulsar?

Rok Povodnik added 6 commits April 14, 2025 11:56
JasperFx#1326 refactoring - substituted ISupportRetryLetterQueue (to …
b50c751 
…be deleted in next commit) with ISupportNativeScheduling for Pulsar's native retry letter functionality.
JasperFx#1326 refactoring - removed most of not needed constructs fro…
d4c81ac 
…m the previously modified code
JasperFx#1326 refactoring - removed not needed construct from the pre…
ac343d9 
…viously modified code
JasperFx#1326 refactoring - removed not needed construct from the pre…
908b4de 
…viously modified code - removed DotPulsar.Extensions.Resiliency (retry and delay message functionality was not working properly) and created "in-house" retry and DLQ functionalities
JasperFx#1326 refactoring
58e2100
JasperFx#1326 clean-up
4462d5a
@punxrok
Copy link
Author

punxrok commented Apr 25, 2025

@jeremydmiller, I have tried to address your open concerns.

Please check the comments (TODO:) where further clarification is required.

@jeremydmiller jeremydmiller modified the milestone: 4.0 May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punxrok @jeremydmiller