Fix Intel crash in ThemeManager on macOS #13543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add try/catch around themeWindowManager.install() to handle RuntimeException - Prevents crash when native libraries are incompatible with ARM64 architecture - Fixes JabRef#13536
Siedlerchr
reviewed
Jul 14, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
requested changes
Jul 15, 2025
| @@ -75,6 +75,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - When creating a library, if you drag a PDF file containing only a single column, the dialog will now automatically close. [#13262](https://github.com/JabRef/jabref/issues/13262) | |||
| - We fixed an issue where the tab showing the fulltext search results would appear blank after switching library. [#13241](https://github.com/JabRef/jabref/issues/13241) | |||
| - Enhanced field selection logic in the Merge Entries dialog when fetching from DOI to prefer valid years and entry types. [#12549](https://github.com/JabRef/jabref/issues/12549) | |||
| - We fixed an issue where JabRef crashed on startup on Apple Silicon Macs due to native library compatibility issues in the theme manager. [#13536](https://github.com/JabRef/jabref/issues/13536) | |||
There was a problem hiding this comment.
No need; feature was introduced after the last release
| @@ -73,7 +73,13 @@ public ThemeManager(WorkspacePreferences workspacePreferences, | |||
| this.workspacePreferences = Objects.requireNonNull(workspacePreferences); | |||
| this.fileUpdateMonitor = Objects.requireNonNull(fileUpdateMonitor); | |||
| this.updateRunner = Objects.requireNonNull(updateRunner); | |||
| this.themeWindowManager = ThemeWindowManagerFactory.create(); | |||
| ThemeWindowManager tempThemeWindowManager = null; | |||
There was a problem hiding this comment.
We do not use "temp" prefix in JabRef. Do without.
With "this." you have the different scoping.
Maybe do without local variable and in the catch block set to null?
| try { | ||
| tempThemeWindowManager = ThemeWindowManagerFactory.create(); | ||
| } catch (UnsatisfiedLinkError | RuntimeException e) { | ||
| LOGGER.error("Failed to create ThemeWindowManager (likely due to native library compatibility issues on ARM64)", e); |
There was a problem hiding this comment.
Do debug instead of warn
It's Intel and not ARM
koppor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13536
Changes
themeWindowManager.install(scene)in ThemeManagerTesting
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)