Add pagination for search based fetchers #13490
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesViewModel.java
Outdated
Show resolved
Hide resolved
|
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
- Clone and create web* (WebImportEntriesDialog and WebImportEntriesDialogViewModel for web implementation) - Cache prev pages in case of page based fetcher
- Enhance the background fetching mechanism for page-based search entries - Fix 'Import Entries' button functionality - Fix display of total and selected items counters - Fix selection buttons behavior (unselectAll, selectAllNewEntries, selectAllEntries)
- generalized fetching of entries for all page-search-based fetcher - improved pageNumberLabel UI - update JabRef_en.properties
|
@trag-bot didn't find any issues in the code! ✅✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5507
This PR introduce pagination for search based fetcher
To Do
WebSteps to testMandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)