Skip to content

Improving Jupyter notebooks in examples/python #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

agodemar
Copy link
Contributor

I started working on the "AoA vs CAS.ipynb" example.
Added more context at the beginning of the notebook.
Added more figures taken from JSBSim online reference manual.
Made a first plot of trimmed states with one weight and one x-cg.
Improved the original plot.

@seanmcleod70
Copy link
Contributor

Looks good.

Noticed a typo in the following, the second one should be $V_{max}$.

a minimum speed $V_{min}$ and a maximum $V_{min}$

Also I didn't see any output graphs in the Jupyter notebook - https://github.com/agodemar/jsbsim/blob/master/examples/python/AoA%20vs%20CAS.ipynb

@agodemar
Copy link
Contributor Author

Also I didn't see any output graphs in the Jupyter notebook - https://github.com/agodemar/jsbsim/blob/master/examples/python/AoA%20vs%20CAS.ipynb

@seanmcleod70 is there a wrong setting that prevents the upload of images embedded in the Jupyter notebook?

@agodemar
Copy link
Contributor Author

@seanmcleod70 Ok, I'll close this and I'll send another PR.

The example https://github.com/agodemar/jsbsim/blob/master/examples/python/AoA%20vs%20CAS.ipynb now renders correctly.

@agodemar
Copy link
Contributor Author

Closing and sending a new PR

@agodemar agodemar closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants