Fixes #33 / Updated csproj file. Updated yml files with new dotnet command fixed… #34
Conversation
…up some GitVersion commands.
WalkthroughThe changes update CI and release workflows to use .NET 8.0 instead of 6.0, alter the method for installing GitVersion, and modify the NuGet publishing command. The GitVersion configuration is simplified, with branch definitions adjusted and versioning conventions updated. The unit testing project is also retargeted to .NET 8.0. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Runner
participant dotnet
participant GitVersion
participant NuGet
GitHub Actions->>Runner: Start CI/Release workflow
Runner->>dotnet: Install .NET 8.0 SDK
Runner->>dotnet: Install GitVersion.Tool (5.12.0) globally
Runner->>GitVersion: Generate version info
Runner->>dotnet: Build and package project
Runner->>dotnet: Push .nupkg to NuGet with API key
dotnet->>NuGet: Upload package
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/NetCore.Utilities.UnitTesting/NetCore.Utilities.UnitTesting.csproj (1)
21-21: Confirm TargetFramework update to .NET 8.0
Verify that retargeting to<TargetFramework>net8.0</TargetFramework>aligns with all consumers and downstream pipelines. Consider multi-targeting (e.g.,net6.0;net8.0) if backward compatibility is required, and review NuGet package dependencies (EF Core 7) for compatibility or upgrade to EF Core 8.GitVersion.yml (1)
4-8: Review ‘main’ branch configuration
Usingregex: mainmay only match literal “main”; consider anchoring with^main$for precision. Also, an emptysource-brancheslist prevents feature-branch metadata—ensure this is intentional..github/workflows/ci-build.yml (1)
27-27: Verify GitVersion.Tool installation path
Installing GitVersion.Tool globally (--global) requires~/.dotnet/toolsto be on thePATHfor subsequent steps. Consider switching to a tool manifest (dotnet tool restore) or explicitly adding the tools directory toPATH..github/workflows/release-build.yml (1)
26-26: Ensure GitVersion.Tool is accessible
InstallingGitVersion.Toolglobally requires~/.dotnet/toolsonPATH. Consider using a manifest (dotnet tool restore) or explicitly exporting the tools path to avoid “command not found” errors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci-build.yml(1 hunks).github/workflows/release-build.yml(2 hunks)GitVersion.yml(1 hunks)src/NetCore.Utilities.UnitTesting/NetCore.Utilities.UnitTesting.csproj(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
GitVersion.yml
[error] 3-3: trailing spaces
(trailing-spaces)
.github/workflows/ci-build.yml
[error] 25-25: trailing spaces
(trailing-spaces)
.github/workflows/release-build.yml
[error] 24-24: trailing spaces
(trailing-spaces)
🪛 GitHub Actions: CI Build
GitVersion.yml
[error] 1-1: GitVersion step failed: output is not valid JSON, indicating a problem with version calculation or configuration.
🔇 Additional comments (5)
GitVersion.yml (2)
2-2: Reset initial version to 1.0.0 requires confirmation
Resettingnext-versionfrom6.0.5to1.0.0will restart semantic versioning; confirm this aligns with your release schedule and that downstream workflows handle the jump appropriately.
11-14: Validate ‘pull-request’ tagging settings
Renaminglabel→tagandlabel-number-pattern→tag-number-patternis correct, but verify your PR naming conventions (e.g.,pr/123) fit(pull|pull\-requests|pr)[/-]and the tag-number regex. Also confirmprevent-increment-of-merged-branch-version: falsealigns with your version-control policy..github/workflows/ci-build.yml (1)
24-24: Upgrade CI to .NET SDK 8.0.x
Retargeting CI to8.0.xaligns with the project; ensure that no remaining workflows or scripts reference the old SDK (6.0.x)..github/workflows/release-build.yml (2)
23-23: Upgrade release workflow to .NET SDK 8.0.x
Updatingactions/setup-dotnet@v4todotnet-version: 8.0.xis consistent with CI and project. Verify there are no residual 6.0 references.
40-40: ```shell
#!/bin/bash
sed -n '1,200p' .github/workflows/release-build.yml</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/ci-build.yml (1)
25-25: Remove trailing whitespace
These blank lines contain trailing spaces and should be cleaned up to satisfy YAML lint rules.Also applies to: 28-28
.github/workflows/release-build.yml (2)
24-24: Remove trailing whitespace
Several lines contain trailing spaces, which YAML lint flags as errors. Please trim these to avoid lint failures.Also applies to: 27-27, 33-33, 38-38
40-40: Publish packages via the dotnet CLI
Switching todotnet nuget pushwith a Unix-style glob is modern and works cross-platform. Consider adding--skip-duplicateto avoid failures if the package already exists in NuGet.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-build.yml(1 hunks).github/workflows/release-build.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ci-build.yml
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
.github/workflows/release-build.yml
[error] 24-24: trailing spaces
(trailing-spaces)
[error] 27-27: trailing spaces
(trailing-spaces)
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
🔇 Additional comments (6)
.github/workflows/ci-build.yml (3)
24-24: Upgrade .NET SDK to 8.0.x
Updating the workflow to target .NET 8.0 aligns with the project retargeting.
27-27: Install GitVersion.Tool as a global tool
Usingdotnet tool install --global GitVersion.Tool --version 5.12.0is valid, but verify that the tool’s install path (typically$HOME/.dotnet/tools) is added toPATHso the CLI is available for the execute step.
31-31: Verify GitVersion execute action version
The workflow now usesgittools/actions/gitversion/execute@v0.10.2, which is significantly older than the previousv3.xversions. Ensure this downgrade is intentional and that it fully supports .NET 8.0. You can check consistency across workflows with:#!/bin/bash # Check GitVersion execute action versions in workflows rg -n "gittools/actions/gitversion/execute@" .github/workflows.github/workflows/release-build.yml (3)
23-23: Upgrade .NET SDK to 8.0.x
Aligns the release pipeline with the updated target framework.
27-27: Install GitVersion.Tool as a global tool
Consistent with the CI build, but confirm that version5.12.0is the intended release and that the global tool path is inPATH.
31-31: Verify GitVersion execute action version
This step usesgittools/actions/gitversion/execute@v0.10.2. Confirm that this version is intentional and fully compatible, or consider aligning with the latest stable execute action.
Updated the target framework for the solution. Updated the yml files with new GitVersions and dotnet commands.
Summary by CodeRabbit